Review PR 1109 string character offset handling#1110
Closed
ericcrosson-bitgo wants to merge 2 commits intomasterfrom
Closed
Review PR 1109 string character offset handling#1110ericcrosson-bitgo wants to merge 2 commits intomasterfrom
ericcrosson-bitgo wants to merge 2 commits intomasterfrom
Conversation
…dates Bumps the dependencies group with 3 updates in the / directory: [@swc/core](https://github.com/swc-project/swc), [@swc/core-linux-x64-gnu](https://github.com/swc-project/swc) and [@swc/core-darwin-arm64](https://github.com/swc-project/swc). Updates `@swc/core` from 1.5.7 to 1.10.6 - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](swc-project/swc@v1.5.7...v1.10.6) Updates `@swc/core-linux-x64-gnu` from 1.5.7 to 1.10.6 - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](swc-project/swc@v1.5.7...v1.10.6) Updates `@swc/core-darwin-arm64` from 1.5.7 to 1.10.6 - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](swc-project/swc@v1.5.7...v1.10.6) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: "@swc/core-linux-x64-gnu" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: "@swc/core-darwin-arm64" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…extraction SWC (written in Rust) provides byte-based span offsets, but JavaScript strings use character-based offsets (UTF-16 code units). When source code contains multibyte UTF-8 characters (e.g., À, 日, 😀), directly using SWC's byte offsets with String.slice() results in incorrect string extraction. This commit introduces byteOffsetToCharOffset() which properly converts byte offsets to character offsets by iterating through the string and accumulating byte lengths until reaching the target byte position. Test cases added for: - Extended Latin characters (2-byte UTF-8: À, ÿ, ñ, ü) - CJK characters (3-byte UTF-8: 日本語, 中文, 한국어) - Mixed multibyte characters at multiple positions - Multibyte characters at the very start of a file Fixes: DX-2788
ericcrosson-bitgo
changed the base branch from
master
to
DX-2788-handle-multibyte
Contributor
Author
|
Superseded by #1111 (nice number) |
ericcrosson-bitgo
deleted the
claude/review-pr-1109-string-offsets-QvruR
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.