feat(sdk-core): add console sanitization for sensitive data#8016
Open
rishikeshdadam136 wants to merge 2 commits intomasterfrom
Open
feat(sdk-core): add console sanitization for sensitive data#8016rishikeshdadam136 wants to merge 2 commits intomasterfrom
rishikeshdadam136 wants to merge 2 commits intomasterfrom
Conversation
mullapudipruthvik
previously approved these changes
Feb 3, 2026
Implements custom logger to prevent token exposure in test/staging environments. Replaced 111 console statements across 52 files with logger that redacts sensitive keys (token, bearer, prv, privatekey, password, otp) and v2x bearer tokens. Technical changes: - Created sanitizeLog.ts with recursive sanitization (O(1) Set lookups) - Created logger.ts with conditional sanitization (test/staging only) - Exported logger from sdk-core for SDK-wide access - Updated 52 files across express, sdk-core, sdk-api, abstract, coin, and utility modules Ticket: WP-7503
rishikeshdadam136
force-pushed
the
WP-7503
branch
from
026eeaf to
30ada75
Compare
OttoAllmendinger
requested changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
please revert changes to utxo-bin, it's a dev tool that needs to print input verbatim
Contributor
There was a problem hiding this comment.
we do not want to introduce a dep to @bitgo/sdk-core here
OttoAllmendinger
requested changes
Feb 4, 2026
Implements custom logger to prevent token exposure in test/staging environments. Replaced 111 console statements across 52 files with logger that redacts sensitive keys (token, bearer, prv, privatekey, password, otp) and v2x bearer tokens. Technical changes: - Created sanitizeLog.ts with recursive sanitization (O(1) Set lookups) - Created logger.ts with conditional sanitization (test/staging only) - Exported logger from sdk-core for SDK-wide access - Updated 52 files across express, sdk-core, sdk-api, abstract, coin, and utility modules Ticket: WP-7503
OttoAllmendinger
requested changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
the sdk-core dep is pretty massive
better move this to a more focused, lightweight package @bitgo/logger
Author
There was a problem hiding this comment.
ok i will move it @bitgo/logger.
Thank you
Author
There was a problem hiding this comment.
I will push again after all the changes
| const SENSITIVE_KEYS = new Set([ | ||
| 'token', | ||
| 'bearer', | ||
| 'prv', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'prv', | |
| 'prv', | |
| 'xprv', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automatic console log sanitization in test/staging environments to prevent token exposure for all BitGoJS SDK users. Sanitizes 6 sensitive keys (token, bearer, prv, privatekey, password, otp) and v2x bearer tokens before logging.
Technical changes:
Ticket: WP-7503