Extend OkComputer to enable a HEAD check#4
Merged
jason-raitz merged 5 commits intomainfrom Feb 4, 2026
Merged
Conversation
awilfox
approved these changes
Feb 2, 2026
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Looks good. r+ after comment removal.
Member
|
This also supports AP-534, if you want to note that somewhere. |
anarchivist
reviewed
Feb 2, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
looking good - i'm hoping we can address the timeout. this might require some changes to BerkeleyLibrary::Util::URIs::Requester. r+ pending addressing/discussing that.
- also makes some rubocop and coverage related changes
awilfox
reviewed
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of our applications now use the OkComputer gem for health checks. This is great for health checks that use GET requests. However, there are some connections where a full GET request takes too long and/or has too much overhead when all we want to know is that the URI returns a HTTP status of 200 OK.
OkComputer uses the open-uri library, so it is not able to make HEAD requests. To extend that ability, this PR will add a HeadCheck class that extends HttpCheck to add an override for OkComputer's perform_request method that uses this gem's wrapper for the rest-client gem.
Supports recent and active tickets like AP-534 & AP-536.