Merged
Conversation
anarchivist
approved these changes
Jan 26, 2026
awilfox
force-pushed
the
awilfox/cleanup-gemfile
branch
2 times, most recently
from
dc6fbd1 to
034cc5f
Compare
Member
Author
|
v2: Squash into single commit. v3: Rebase against latest changes. Will merge after CI passes. |
Member
Author
|
@anarchivist should this commit be tagged AP-561, AP-270, both, or neither? |
davezuckerman
approved these changes
Jan 27, 2026
Member
|
@awilfox tag it as AP-270, even though it may not cover everything. |
* `typesafe_enum` was only used by the old health check code, which was removed from the codebase in 1371798. * `awesome_print` was used by the custom logging code, but has since been replaced with berkeley_library-logging (which still requires it). There are no direct dependencies on awesome_print in the codebase, so this can be removed from our direct Gemfile dependencies. * We do not use JBuilder for any of our JSON responses. This was added in the initial commit by Rails scaffolding and is not used anywhere. * When Framework was converted to RSpec in f7501f5 (2019), we also stopped using VCR. The reference in the Gemfile was missed. Ref: AP-270
awilfox
force-pushed
the
awilfox/cleanup-gemfile
branch
from
034cc5f to
1630dea
Compare
Member
Author
|
v4: Tagged AP-270. now will merge after CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes unused Gems. I will flatten this down to a single commit before merging, but each change is listed here separately for comment/review.