models: Validate Bibliographic::HostBibTask.email

[awilfox]

This ensures we do not create jobs without email addresses.

Closes: AP-577

---

@yzhoubk since you were the one who was running into jobs without email addresses while testing #10, would you be able to try this branch out and see if this helps?

I'm wondering if one of the test jobs was firing off, since they didn't specify an email. At any rate, having this validation should help us catch out any places we're missing the email in the future.

[awilfox]

fascinating, neither of those tests fail on my local computer.

[yzhoubk]

@awilfox I pulled the branch and tested it locally, when uploaded a bib batch, it gave a 500 error. Could you try it locally with these steps?

1. Go to http://localhost:3000/bibliographics
2. Select the text file: /spec/data/upload_file.txt
3. Submit

For the previous error 'ArgumentError: SMTP to address may not be blank: [].', I login in Calnet, how can my email is blank? All calnet user should have an email. We need some investigation on it.

[davezuckerman]

This is using an email of a former employee in LIT. I think they probably put it in there but not sure if we should still be using it. Looks like it's used in several places

[awilfox]

I copied that from the same identifier in spec/data/alma_patrons - I agree it's not ideal, but it was for testing purposes.

[awilfox]

I think I've figured out the underlying issue why emails were blank. We are receiving the email address as berkeleyEduAlternateID, not berkeleyEduAlternateId. I can't tell if Rails 7.1 made a change that caused this hash to be case sensitive where it didn't used to be, or if the underlying CalNet system changed as a coincidence.

At any rate, I think that change needs to be separate from this one, so I will open a new branch for that change, and then rebase this one.