added a few accesibility checks. more to come. by marijndaniels · Pull Request #202 · Behatch/contexts

marijndaniels · 2017-03-07T09:19:27Z

Extending the BaseContext for some accesibility checks.

Plan to add these as well:

Headings:
** each page should have one and only one H1 element.
** the H1 element should not be longer than 70 chars in length.
** each page should have at least one H2 element
Images
** Each image should have an alt attribute, possibly empty.
** If a title attribute is present, it should differ in value from the alt attribute
Tables
Each table should have a heading and at least one data row
Anchors
** for each a:hover there should also be an a:focus
** title attribute should differ in value from the text in between the a tags
Forms
** each formfield should have a label
** all labels should have a for attribute, linked to the formfield
Page
** check for skip navigation
** check doctype present
** check lang attribute

sanpii

Great idea!

Please add a test for these definitions.

It’s maybe a good idea to add a reference from w3c standard in error messages. For example, in the first text error message, I have added a link to https://www.w3.org/TR/WCAG10/#gl-provide-equivalents

sanpii · 2017-03-07T10:27:39Z

src/Context/AccesibilityContext.php

@@ -0,0 +1,49 @@
+<?php
+
+namespace Sanpi\Behatch\Context;


Since the last version, the right namespace is Behatch\Context.

also test added

sanpii · 2017-03-07T10:28:05Z

src/Context/AccesibilityContext.php

+class AccesibilityContext extends BaseContext
+{
+
+    public function __construct()


No empty construct.

sanpii · 2017-03-07T10:30:22Z

src/Context/AccesibilityContext.php

+    public function allImagesShouldHaveAnAltAttribute()
+    {
+        $images = $this->getSession()->getPage()->findAll('xpath', '//img[not(@alt)]');
+        if ($images != null) {


Use strict (===) equality.

sanpii · 2017-03-07T10:30:28Z

src/Context/AccesibilityContext.php

+    public function allTablesShouldHaveATableHeader()
+    {
+        $tables = $this->getSession()->getPage()->findAll('xpath', '//table/*[not(th)]');
+        if ($tables != null) {


Use strict (===) equality.

sanpii · 2017-04-13T18:29:06Z

src/class_aliases/Context/AccesibilityContext.php

+
+@trigger_error('The Sanpi\\Behatch\\Context\\AccesibilityContext class is deprecated since version 2.3 and will be removed in 3.0. Use the Behatch\\Context\\AccesibilityContext class instead.', E_USER_DEPRECATED);
+
+class_alias('\\Behatch\\Context\\AccesibilityContext', '\\Sanpi\\Behatch\\Context\\AccesibilityContext');


I don’t think it's necessary.

sanpii · 2017-04-13T18:29:58Z

tests/features/accesibility.feature

@@ -0,0 +1,48 @@
+  @accesibility
+  Feature: toegankelijkheid verschillende types paginas


Please use english language.

sanpii · 2017-04-13T18:30:45Z

tests/features/accesibility.feature

+    Then I should see 1 "h1" elements
+    And I should see an "h2" element
+
+  Examples:


It’s not necessary if you have only one url.

sanpii · 2017-04-13T18:30:49Z

tests/features/accesibility.feature

+    Given I am on "<url>"
+    Then the title should not be longer than 70
+
+  Examples:


It’s not necessary if you have only one url.

sanpii · 2017-04-13T18:30:54Z

tests/features/accesibility.feature

+    Given I am on "<url>"
+    Then all images should have an alt attribute
+
+  Examples:


It’s not necessary if you have only one url.

sanpii · 2017-04-13T18:30:58Z

tests/features/accesibility.feature

+    Given I am on "<url>"
+    Then all tables should have a table header
+
+  Examples:


It’s not necessary if you have only one url.

sanpii · 2017-04-13T18:31:02Z

tests/features/accesibility.feature

+    Given I am on "<url>"
+    Then all tables should have at least one data row
+
+  Examples:


It’s not necessary if you have only one url.

sanpii · 2017-04-13T18:31:54Z

src/Context/AccesibilityContext.php

+    /**
+     * @Then the title should not be longer than :arg1
+     */
+    public function theTitleShouldNotBeLongerThan($arg1)


Use explicite argument name, like $length

sakonachhoeurng · 2017-08-23T04:54:34Z

src/Context/AccesibilityContext.php

+     */
+    public function allImagesShouldHaveAnAltAttribute()
+    {
+        $images = $this->getSession()->getPage()->findAll('xpath', '//img[not(@alt)]');


Hi, could you tell me this would refer to test image without alt?
I pull your code and test my website. There are alt attribute, but still said There are images without an alt attribute

added a few accesibility checks. more to come.

85fb5aa

sanpii suggested changes Mar 7, 2017

View reviewed changes

Marijn Daniels added 4 commits March 7, 2017 12:48

removed constructor and used strict value&type comparison

83e3e5c

changed namespace

896ea3a

test added for accesibility feature

a81908e

added class alias

e3060e2

sanpii suggested changes Apr 13, 2017

View reviewed changes

sanpii added this to the 2.7 milestone Apr 13, 2017

sanpii removed this from the 2.7 milestone Apr 28, 2017

sakonachhoeurng reviewed Aug 23, 2017

View reviewed changes


		@trigger_error('The Sanpi\\Behatch\\Context\\AccesibilityContext class is deprecated since version 2.3 and will be removed in 3.0. Use the Behatch\\Context\\AccesibilityContext class instead.', E_USER_DEPRECATED);

		class_alias('\\Behatch\\Context\\AccesibilityContext', '\\Sanpi\\Behatch\\Context\\AccesibilityContext');

		@@ -0,0 +1,48 @@
		@accesibility
		Feature: toegankelijkheid verschillende types paginas

Conversation

marijndaniels commented Mar 7, 2017

Uh oh!

sanpii left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants