This repository was archived by the owner on Jul 19, 2024. It is now read-only.
Updated BlobRequestOptions.java#519
Open
sjoshi570 wants to merge 1 commit intoAzure:legacy-masterfrom
Open
Conversation
singleBlobPutThresholdInBytes property default size is mentioned as 32 MB. The default threshold size is set in the client and is by default 32MB. You can change the threshold size on this request by setting this property. I have updated this one to 132 MB. As per the discussion I had with MSFT Storage SMEs, this is a documentation bug. (256 * 1024 * 1024) / 2 = 134217728, this is what the default threshold size is coming. Follow below Teams link for more details: https://teams.microsoft.com/l/message/19:3e1c65a38017478b86ad318bf03a1f65@thread.skype/1576580014301?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=8a6a0fe1-0d7d-41a0-93f0-0fd7af9ac2c8&parentMessageId=1576505277402&teamName=PaaS%20Developer%20POD%20Global&channelName=Storage&createdTime=1576580014301
Contributor
|
@sjoshi570 Thank you for catching this doc bug and submitting a fix. Although there is some skew involved when looking at the exact number of bytes, I think we would prefer to use 128MB as that is a more accurate representation of 256MB/2. If you could update it accordingly, we would be happy to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
singleBlobPutThresholdInBytes property default size is mentioned as 32 MB.
The default threshold size is set in the client and is by default 32MB. You can change the threshold size on this
request by setting this property.
I have updated this one to 132 MB.
As per the discussion I had with MSFT Storage SMEs, this is a documentation bug.
(256 * 1024 * 1024) / 2 = 134217728, this is what the default threshold size is coming.
Follow below Teams link for more details:
https://teams.microsoft.com/l/message/19:3e1c65a38017478b86ad318bf03a1f65@thread.skype/1576580014301?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=8a6a0fe1-0d7d-41a0-93f0-0fd7af9ac2c8&parentMessageId=1576505277402&teamName=PaaS%20Developer%20POD%20Global&channelName=Storage&createdTime=1576580014301