Fix hang when closing connections under load#2575
Open
nvartolomei wants to merge 1 commit intoAzure:mainfrom
Open
Fix hang when closing connections under load#2575nvartolomei wants to merge 1 commit intoAzure:mainfrom
nvartolomei wants to merge 1 commit intoAzure:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
8 tasks
c3b8e4f to
0551c02
Compare
This comment was marked as resolved.
This comment was marked as resolved.
0551c02 to
70d0d06
Compare
Member
|
@nvartolomei @XiaoningLiu , @EmmaZhu, |
EmmaZhu
approved these changes
Aug 6, 2025
70d0d06 to
7382c5c
Compare
…erationQueue processes the request In Azurite, all operations are managed through concurrent operation queues. A bug was identified where operations could hang indefinitely if the client disconnected before the operation was processed. This occurred because Azurite would attempt to attach event handlers to the request's readable stream (body) after it had already been closed by the client's disconnection. Since a closed stream emits no further events (like 'data', 'close', or 'error'), the operation would never complete, causing a permanent hang. This fix addresses the issue by checking if the request stream is still readable before attaching any event handlers. This ensures that we only process requests that are still active, preventing the hang and allowing the queues to continue processing other operations.
7382c5c to
fe3b28e
Compare
|
@EmmaZhu would be great to merge this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
mainbranch.legacy-devbranch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Releasesection inChangeLog.md.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.