Implement count in expansion options#197
Open
lenardchristopher wants to merge 2 commits intoAutoMapper:masterfrom
Open
Implement count in expansion options#197lenardchristopher wants to merge 2 commits intoAutoMapper:masterfrom
lenardchristopher wants to merge 2 commits intoAutoMapper:masterfrom
Conversation
Author
|
@dotnet-policy-service agree |
Member
|
It's probably better to place the test here. The test should confirm that the count filed exists in the result. It should fail if run against the current code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #137
Note: First time touching the code of this repo. I don't see any contribution docs, so I'm not sure what is necessary.
The test I wrote fails with the following exception
I interpret this to mean that
COUNTwas used properly, but handling the value in the result is throwing an error. Would love some advice. Thanks.