Open
Conversation
yousifS
reviewed
May 18, 2020
| Created different classes to hold the attributes and move them from array to array, and display them in the DOM. Created a listPeopleChoices function to create new players and map through the array of people. Creates a button that allows you to make a player that when clicked moves the object to the listOfPlayers array. Once listOfPlayers is created they are given two button options for the red or blue team which when clicked will move them to the selected array. | ||
| step 1: Array of People | ||
| step 2: ARRAY OF PLAYERS | ||
| STEP 3: array of red or blue team |
There was a problem hiding this comment.
One of the requirements was a test plan write up, or some tests. I dont see either of those.
yousifS
reviewed
May 18, 2020
| }; | ||
|
|
||
| const makeBluePlayer = (player) => { | ||
|
|
There was a problem hiding this comment.
This would have been the place to create a Teammate instance and have it store the team color.
yousifS
reviewed
May 18, 2020
| @@ -0,0 +1,202 @@ | |||
| const arrOfPeople = [ | |||
There was a problem hiding this comment.
I really like that you put comments through out. But the indentation could use a little more work. It is not strictly necessary for the code to run, but it would make it easier to read and follow along
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3