feat: adapt to node v10 requirements for overloading#73
Open
icyJoseph wants to merge 1 commit intoAudioNet:masterfrom
Open
feat: adapt to node v10 requirements for overloading#73icyJoseph wants to merge 1 commit intoAudioNet:masterfrom
icyJoseph wants to merge 1 commit intoAudioNet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As node v10 takes over, it seems that some changed are required.
From what I've managed to understand NaN upgraded the usage of their methods. That's why the application complains about overloading.
This PR is pretty much based of this examples:
https://github.com/nodejs/nan/blob/master/doc/object_wrappers.md#examples