asahi-diagnose: Use hostnamectl to fetch hostname#25
Open
emberdex wants to merge 4 commits intoAsahiLinux:mainfrom
Open
asahi-diagnose: Use hostnamectl to fetch hostname#25emberdex wants to merge 4 commits intoAsahiLinux:mainfrom
emberdex wants to merge 4 commits intoAsahiLinux:mainfrom
Conversation
Signed-off-by: b-crumb <shadow.sandlot.tribute@proton.me>
Signed-off-by: b-crumb <shadow.sandlot.tribute@proton.me>
Signed-off-by: Leif Liddy <leif.liddy@gmail.com>
A default installation of Asahi Linux doesn't appear to come included with the `hostname` binary. This causes the hostname lookup to fail when asahi-diagnose is used. This technically ties the script to systemd, so a better solution if this becomes a concern (i.e. if different init systems are offered in the future) might be to check for the presence of the `hostname` binary, and if it's not present, go with a sensible alternative value instead of erroring out. Signed-off-by: Toby Jones <github@monotron.me>
|
Unfortunately, the script is already tied to systemd, as it calls Would there be support for making this script a bit more modular in that regard? |
davide125
requested changes
Apr 16, 2025
Member
davide125
left a comment
davide125
left a comment
There was a problem hiding this comment.
There's a bunch of unrelated commits in here, could you rebase it please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A default installation of Asahi Linux doesn't appear to come included with the
hostnamebinary. This causes the hostname lookup to fail when asahi-diagnose is used.This technically ties the script to systemd, so a better solution if this becomes a concern (i.e. if different init systems are offered in the future) might be to check for the presence of the
hostnamebinary, and if it's not present, go with a sensible alternative value instead of erroring out.