Remove ProtocolLib dependency, update to newest Spigot, fix POM to not shade in everything#1
Open
vemacs wants to merge 10 commits intoArkhamNetwork:masterfrom
Open
Remove ProtocolLib dependency, update to newest Spigot, fix POM to not shade in everything#1vemacs wants to merge 10 commits intoArkhamNetwork:masterfrom
vemacs wants to merge 10 commits intoArkhamNetwork:masterfrom
Conversation
vemacs
commented
Sep 22, 2014
- ProtocolLib is unnecessary for determining a player's client version
- Spigot builds after 0916a add an extra boolean for lighting fix to teleport packets, breaking the constructor, this fixes it
- Old POM literally shaded in all of Spigot, this only shades in Updater and Metrics-lite
- Better 1.8 client support by continuously forcing a resend
|
10/10 would merge |
|
I wouldnt use the NMS you implemented for the protocol version check, but apart from that looks good. |
Author
|
BarAPI is version dependent anyways, so the NMS doesn't hurt. I do have it implemented with reflection, but given that there won't ever be a new versioned package plus BarAPI is version dependent anyways, it really shouldn't matter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.