Improve ArduCAM_Touch read() and constructor safety#598
Open
Chris0xdeadbeef wants to merge 3 commits intoArduCAM:masterfrom
Open
Improve ArduCAM_Touch read() and constructor safety#598Chris0xdeadbeef wants to merge 3 commits intoArduCAM:masterfrom
Chris0xdeadbeef wants to merge 3 commits intoArduCAM:masterfrom
Conversation
…y zero Use uint8_t for loop index to match the `prec` type (byte). Replace i++ with ++i (minor micro-optimization). Add if (prec > 0) check before dividing tx and ty to prevent division by zero.
Initialize `prec` to 10 in ArduCAM_Touch constructor. Ensures that read() works safely even if setPrecision() is not called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use uint8_t for loop index in read() and add if (prec > 0) to prevent division by zero.
Initialize prec via constructor initializer list (: prec(10)) for a safe default.
Minor refactor: replace i++ with ++i.
Benefits: safer read(), cleaner code, and better C++ practices, no API changes.