Open
Conversation
Further trying to clean up interface so that `IChatSessionsService` consumers don't know about providers directly
Remove `notifySessionItemsChanged`
Update monaco to target lib es2024
Don't return providers in `IChatSessionsService` methods
…anguage-features (#292649) Bump @isaacs/brace-expansion in /extensions/css-language-features Bumps @isaacs/brace-expansion from 5.0.0 to 5.0.1. --- updated-dependencies: - dependency-name: "@isaacs/brace-expansion" dependency-version: 5.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Since ebaa450 the following sequence can happen: 0. User triggers and then closes UI for a new background session 1. An agent makes edits to files in a background chat session 2. The files are modified in the session, and then kept automatically 3. The untitled chat completes. Because there is now no active UI and newly no modified files in the session (so the self-refs in ChatModel constructor/startEditingSession are not being maintained) the session is disposed. 4. Migration from the untitled->titled session happens. However as the session is now disposed, when the edit session is transferred, the text models used to drive the edit session is gone and the migration fails. 5. This leaves the world in a torn state and causes #292174. Fix was to address the underlying issue and hold a reference to the untitled session while the migration happened to avoid transferring disposed model.
…language-features (#292651) Bump @isaacs/brace-expansion in /extensions/json-language-features Bumps @isaacs/brace-expansion from 5.0.0 to 5.0.1. --- updated-dependencies: - dependency-name: "@isaacs/brace-expansion" dependency-version: 5.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…language-features (#292656) Bump @isaacs/brace-expansion in /extensions/html-language-features Bumps @isaacs/brace-expansion from 5.0.0 to 5.0.1. --- updated-dependencies: - dependency-name: "@isaacs/brace-expansion" dependency-version: 5.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Remove default formatter workspace setting for js/ts
* chat: initial wip on request queuing * make it work reasonably
Fix for agent sessions welcome close telemetry
Update distro for env extension taskExecution
…ngs with immediate toggling (#292679) * Initial plan * Add ChatContextKeys.enabled check to Simple Browser overlay - Import ChatContextKeys and observableContextKey - Add IContextKeyService injection to SimpleBrowserOverlayController - Check ChatContextKeys.enabled in constructor (early exit if disabled) - Observe chatEnabled state reactively in autorun to hide overlay when AI features are disabled - Hide overlay when either chat is disabled or no active editor Co-authored-by: jruales <1588988+jruales@users.noreply.github.com> * Remove trailing whitespace Co-authored-by: jruales <1588988+jruales@users.noreply.github.com> * Fix overlay reappearing when AI features are re-enabled Remove early exit check for ChatContextKeys.enabled in constructor. The reactive autorun already handles showing/hiding based on chat enabled state, so the controller should always initialize to allow dynamic toggling of AI features without requiring VS Code restart. Co-authored-by: jruales <1588988+jruales@users.noreply.github.com> * Make chat.sendElementsToChat.enabled reactive for immediate toggling - Import observableConfigValue utility - Remove early exit check for sendElementsToChat.enabled - Create observable for chat.sendElementsToChat.enabled configuration - Update autorun to also check isSendElementsEnabled - Overlay now shows/hides immediately when toggling both chat.disableAIFeatures and chat.sendElementsToChat.enabled Co-authored-by: jruales <1588988+jruales@users.noreply.github.com> * Fix default --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jruales <1588988+jruales@users.noreply.github.com>
Weird destructing artifact from js -> ts rewrite was messing up references
* fix: rename product executable name on macOS * chore: update test/automation/src/electron.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: update test/automation/src/electron.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: rename in additional places * chore: rename in code-perf.js * chore: create symlink for backwards compatibility --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fix double hover
sessions: prevent transferring a disposed editing session
Use ts-go for building our extensions
* fix uninstalling deprecated extensions in all profiles * fix tests
Switch to standard import in build file
* Fix quick chat layout Fix #292545 * Simplify
* Update status bar item with hovers * PR feedback, revert test change * Added setting to control update status bar visibility * Rename 'onAction' to 'actionable' for update status bar setting * Bug fixes * Fix flaky tests
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bumps [bytes](https://github.com/tokio-rs/bytes) from 1.6.0 to 1.11.1. - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.6.0...v1.11.1) --- updated-dependencies: - dependency-name: bytes dependency-version: 1.11.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.100.0 to 5.105.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Changelog](https://github.com/webpack/webpack/blob/main/CHANGELOG.md) - [Commits](webpack/webpack@v5.100.0...v5.105.0) --- updated-dependencies: - dependency-name: webpack dependency-version: 5.105.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps ghcr.io/devcontainers/features/rust from 1.3.3 to 1.5.0. --- updated-dependencies: - dependency-name: ghcr.io/devcontainers/features/rust dependency-version: 1.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…92929) Bumps [@modelcontextprotocol/sdk](https://github.com/modelcontextprotocol/typescript-sdk) from 1.25.2 to 1.26.0. - [Release notes](https://github.com/modelcontextprotocol/typescript-sdk/releases) - [Commits](modelcontextprotocol/typescript-sdk@v1.25.2...v1.26.0) --- updated-dependencies: - dependency-name: "@modelcontextprotocol/sdk" dependency-version: 1.26.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ns list when stacked (#293506) * chat / sessions - adopt `max-width` rule for session title and sessions list when stacked * Update src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/media/chatViewPane.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/media/chatViewTitleControl.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add onDidExecuteHook event to HooksExecutionService * Fix MockHooksExecutionService to include onDidExecuteHook event * Extend Disposable instead of using DisposableStore * Fire onDidExecuteHook event even when no hooks are registered * Fixes
* Improve tests * Handle multiple post/preToolUse hooks more correctly
* feat: add vision policy handling for image attachments * Initial plan * Make IDefaultAccountService optional in image attachment widgets Made IDefaultAccountService optional in ImageAttachmentWidget and NotebookCellOutputChatAttachmentWidget to prevent test failures when the service is not stubbed. This follows the existing pattern with ITerminalService and treats missing policy data as "enabled" (vision allowed). Co-authored-by: cwebster-99 <60238438+cwebster-99@users.noreply.github.com> * add service stub to workbenchTestServices * use entitlements service * Update warning message and remove unused imports * hygeine --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: justschen <justchen@microsoft.com> Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com>
Implements drag-and-drop functionality to reorder steering and queued pending messages within their respective groups. When more than one message of the same kind is pending, a gripper handle appears on hover that enables dragging to reorder. - Adds ChatPendingDragController to manage drag state, insertion indicators, and reorder logic via event delegation on the list container, keeping logic cleanly isolated from the renderer - Attaches drag handles to pending request rows via the renderer with one-way binding; reorder operations call chatService.setPendingRequests which automatically triggers the full refresh chain - Prevents cross-group reordering: steering messages stay within steering, queued messages stay within queued - Adds CSS for drag handle visibility on hover, dragging state opacity, and insertion indicator positioning - All changes compile cleanly with no layering violations Fixes #293473 (Commit message generated by Copilot)
* Support for confirmation with custom buttons via toolcall * Updated tests
Bumps [tar](https://github.com/isaacs/node-tar) to 7.5.7 and updates ancestor dependency [dmg-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/dmg-builder). These dependencies need to be updated together. Updates `tar` from 6.2.1 to 7.5.7 - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.2.1...v7.5.7) Updates `dmg-builder` from 26.5.0 to 26.7.0 - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/dmg-builder/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/electron-builder@26.7.0/packages/dmg-builder) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.7 dependency-type: indirect - dependency-name: dmg-builder dependency-version: 26.7.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Enable npm scripts
Includes public API, user setting, status bar icon and a new service to support metered network connections. Updates code in various areas performing automated actions using network to delay/pause network operations while network connection is being metered.
* Polish integrated browser UI: welcome state, input styling, toolbar gaps * Update src/vs/workbench/contrib/browserView/electron-browser/media/browser.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Always show forward button, disable when not usable * Add dev tools icon button, disable until page loaded --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* hooks streaming first pass * Update src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatHookContentPart.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update styling * modify api shape * address some comments + do not render for now * new icons + no more continue * make sure we render right, some comments addressed * uncomment that stuffs --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…on-polish chat: various fixes around queued/steering states
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )