[WIP] TPC QC: adds occupancy histogram in Cluster task

[sbhawani]

No description provided.

[wiechula]

Not needed, nHBF is already set above.

Suggested change

	mQCClusters.getClusters().normalize(grpECS->getNHBFPerTF());
	mQCClusters.getClusters().normalize();

[wiechula]

Most probably these functions will never be called outside this code. So the can be in the private part of the class.
Also, the binning is not needed here, since it is only taken from mRanges via the calDet name. Also, the object should not be modified, so it can be `const.

Suggested change

	void makeRadialProfile(o2::tpc::CalDet<T>& calDet, TCanvas* canv, int nbinsY, float yMin, float yMax);
	void makeRadialProfile(const o2::tpc::CalDet<T>& calDet, TCanvas* canv);

[wiechula]

Here is a problem in the logic, since calDet is a reference to the NClusters cal det. So all subsequent assignments will overwrite the NClusters calDet. Also, there is a lot of unnecessary repetitive code here. I propose to add a simple lambda and replace everything below

auto& clusters = clusterData->getClusters();

with

auto fillCanvases = [&calDetIter, this](const CalDet& calDet) {
  auto vecPtr = toVector(mCalDetCanvasVec.at(calDetIter++));
  const auto& ranges = mRanges[calDet.getName()];
  o2::tpc::painter::makeSummaryCanvases(calDet, int(ranges.at(0)), ranges.at(1), ranges.at(2), false, &vecPtr);
};

  fillCanvases(clusters.getNClusters());
  fillCanvases(clusters.getQMax());

  if (mIsClusters) {
    fillCanvases(clusters.getQTot());
    fillCanvases(clusters.getSigmaPad());
    fillCanvases(clusters.getSigmaTime());
  }

  fillCanvases(clusters.getTimeBin());
  fillCanvases(clusters.getOccupancy());

  makeRadialProfile(calDet, mCalDetCanvasVec.at(calDetIter++).at(0).get());

This should be much more compact and easier to read.

[wiechula]

Suggested change

	void ClusterVisualizer::makeRadialProfile(o2::tpc::CalDet<T>& calDet, TCanvas* canv, int nbinsY, float yMin, float yMax)
	{
	const std::string_view calName = calDet.getName();
	void ClusterVisualizer::makeRadialProfile(const o2::tpc::CalDet<T>& calDet, TCanvas* canv)
	{
	const std::string_view calName = calDet.getName();
	const auto& ranges = mRanges[calName.data()];
	const int nbinsY = int(ranges.at(0));
	const float yMin = ranges.at(1);
	const float yMax = ranges.at(2);

[wiechula]

@sbhawani , please fix the clang-format

[justonedev1]

@wiechula @sbhawani is this PR still relevant?