[PWGHF] Optimized the UPC THnSparse#14802
Open
Rrantu wants to merge 4 commits intoAliceO2Group:masterfrom
Open
[PWGHF] Optimized the UPC THnSparse#14802Rrantu wants to merge 4 commits intoAliceO2Group:masterfrom
Rrantu wants to merge 4 commits intoAliceO2Group:masterfrom
Conversation
Rrantu
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
bot
changed the title
zhangbiao-phy
approved these changes
Feb 4, 2026
lubynets
reviewed
Feb 4, 2026
| /// Fill the ML outputScores and variables of candidate | ||
| std::vector<double> valuesToFill{massLc, pt, rapidity, outputBkg, outputPrompt, outputFD, static_cast<double>(numPvContributors), static_cast<double>(gap), static_cast<double>(fitInfo.ampFT0A), static_cast<double>(fitInfo.ampFT0C), static_cast<double>(fitInfo.ampFV0A), static_cast<double>(fitInfo.ampFDDA), static_cast<double>(fitInfo.ampFDDC), static_cast<double>(zdcEnergyZNA), static_cast<double>(zdcEnergyZNC)}; | ||
| registry.get<THnSparse>(HIST("hnLcUpcVarsWithBdt"))->Fill(valuesToFill.data()); | ||
| if (fillUPCTHnLite) { |
Contributor
There was a problem hiding this comment.
Dear @Rrantu @zhangbiao-phy, sorry for interfering the PR process, but here and in a block below you have two identical actions under if and else. Could you please get rid of this duplication?
Contributor
There was a problem hiding this comment.
Independently on the previous comment: are you sure that your code does what you intended logic-wise? I mean that the UPC THn will be filled both in cases when fillUPCTHnLite is true or false.
And presence of the UPC THn in the registry is conditioned by the fillTHn, not fillUPCTHnLite.
Contributor
Author
There was a problem hiding this comment.
Hi @lubynets, fillUPCTHnLite = true fills only candidates passing the sgselector gap selection, while fillUPCTHnLite = false fills all candidates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary axes from the UPC THnSparse, added the fillUPCTHnLite configurable, and included ZDC timing information in the UPC THnSparse.