Conversation
knopers8
reviewed
Jan 13, 2026
coconut/control/controlutil.go
Outdated
|
|
||
| func formatTimestamp(int64timestamp int64) string { | ||
| timestamp := time.Unix(0, int64timestamp) | ||
| func formatTimestamp(int64timestamp time.Duration) string { |
Collaborator
There was a problem hiding this comment.
the argument name seems to be obsolete, please update
justonedev1
force-pushed
the
OCTRL-634
branch
from
c286003 to
a941c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed formatting of timestamp inside a coconut. We were using ms timestamp as ns field and than reformatting it to seconds precision timestamp. So we now use time.Duration and time.Unix with seconds fields properly.