[O2B-1509] LHCfills scheme name filter#2046
Open
Houwie7000 wants to merge 10 commits intofeature/O2B-1508/lhcfills-beam-types-filterfrom
Open
[O2B-1509] LHCfills scheme name filter#2046Houwie7000 wants to merge 10 commits intofeature/O2B-1508/lhcfills-beam-types-filterfrom
Houwie7000 wants to merge 10 commits intofeature/O2B-1508/lhcfills-beam-types-filterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/O2B-1508/lhcfills-beam-types-filter #2046 +/- ##
===============================================================================
- Coverage 45.71% 45.68% -0.03%
===============================================================================
Files 1039 1040 +1
Lines 17263 17254 -9
Branches 3142 3135 -7
===============================================================================
- Hits 7891 7882 -9
Misses 9372 9372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…re/O2B-1509/lhcfills-scheme-name-filter
ac739fe to
475c273
Compare
…re/O2B-1509/lhcfills-scheme-name-filter update from upstream
Contributor
Author
|
push -f is a correction of the push -f in 1508... |
isaachilly
reviewed
Jan 25, 2026
lib/public/components/Filters/LhcFillsFilter/schemeNameFilter.js
Outdated
Show resolved
Hide resolved
Renamed occurrences of 'schemename' to 'scheme name' in test descriptions and variable names for consistency.
Removed 'scheme-name-filter' class from the scheme name filter component and updated test selectors to use '.fillingSchemeName-filter input' instead so as not to use a class as essentially an ID.
isaachilly
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: