Skip to content

Fix and improve TPC Loopers implementation#15013

Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom
jackal1-66:loopersFix
Feb 4, 2026
Merged

Fix and improve TPC Loopers implementation#15013
sawenzel merged 1 commit intoAliceO2Group:devfrom
jackal1-66:loopersFix

Conversation

@jackal1-66
Copy link
Collaborator

  • Moved the TPCLoopers inclusion to Generator.cxx
  • Made forward declaration for GenTPCLoopers
  • Switched to normal pointer instead of unique_ptr (destroyed in Generator destructor) ==> moved outside ifdef scope, this was the main cause of the segmentation issue when using the external generators, such as Update tune from SCCR to QCDCR for pO and OO O2DPG#2256

@jackal1-66 jackal1-66 requested a review from sawenzel as a code owner February 3, 2026 18:31
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@jackal1-66 jackal1-66 enabled auto-merge (squash) February 4, 2026 13:49
@alibuild
Copy link
Collaborator

alibuild commented Feb 4, 2026

Error while checking build/O2/fullCI_slc9 for 315600e at 2026-02-04 15:13:

++ cp /sw/slc9_x86-64/O2/15013-slc9_x86-64-local1/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/15013-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/15013-slc9_x86-64/0/CMakeLists.txt ]]

Full log here.

@sawenzel sawenzel disabled auto-merge February 4, 2026 16:56
@sawenzel sawenzel merged commit ff39f95 into AliceO2Group:dev Feb 4, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants