Conversation
…Event calibration object
wpierozak
requested review from
afurs,
andreasmolander,
jotwinow and
sahilupadhyaya92
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Please consider the following formatting changes to AliceO2Group#14986
Please consider the following formatting changes to AliceO2Group#14986
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Thanks @wpierozak , a few comments below.
| timestamp = o2::ccdb::getCurrentTimestamp(); | ||
| } | ||
|
|
||
| EventsArray* events = ccdbApi.retrieveFromTFileAny<o2::ft0::EventsPerBc>(ccdbPath, metadata, timestamp); |
There was a problem hiding this comment.
The CI failure is genuine: EventsArray is not defined, should be EventsPerBc?
There was a problem hiding this comment.
I forgot to commit changes here, it should be ok now
| double isVertex = digit.mTriggers.getVertex(); | ||
| if (digit.mTriggers.getAmplA() < mMinAmplitudeSideA || digit.mTriggers.getAmplC() < mMinAmplitudeSideC) { | ||
| continue; | ||
| } | ||
| mTvx[digit.mIntRecord.bc] += isVertex; | ||
| entries += isVertex; |
There was a problem hiding this comment.
Why not simply
if (digit.mTriggers.getVertex() && digit.mTriggers.getAmplA() <= mMinAmplitudeSideA && digit.mTriggers.getAmplC() >= mMinAmplitudeSideC) {
mTvx[digit.mIntRecord.bc]++;
entries++;
}
?
There was a problem hiding this comment.
Your version is better, I have updated this part
| LOG(info) << "Only one object will be created at the end of run"; | ||
| mCalibrator->setUpdateAtTheEndOfRunOnly(); | ||
| } | ||
| if (mOneObjectPerRun == false && mSlotLen == 0) { |
There was a problem hiding this comment.
I guess here you wanted to have mSlotLenSec ?
I would eliminate the option of slotLen in TFs: the framework knows how to converts seconds to the TFs.
| {"slot-len-sec", VariantType::UInt32, 3600u, {"Duration of each slot in seconds"}}, | ||
| {"slot-len-tf", VariantType::UInt32, 0u, {"Slot length in Time Frames (TFs)"}}, | ||
| {"one-object-per-run", VariantType::Bool, false, {"If set, workflow creates only one calibration object per run"}}, | ||
| {"min-entries-number", VariantType::UInt32, 0u, {"Minimum number of entries required for a slot to be valid"}}, |
There was a problem hiding this comment.
Could you add some reasonable default (at least a few K entries) to avoid finalization of empty slots?
… in TFs; Small code cleaning
Please consider the following formatting changes to AliceO2Group#14986
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Thanks, to me looks good. I guess FIT experts will merge it.
3 participants
No description provided.