Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for 748fad9 at 2026-01-20 11:50: Full log here. |
| * | ||
| * FOCAL reconstruction workflow package. See \ref refFOCALworkflow | ||
| * for more information. | ||
| */ No newline at end of file |
There was a problem hiding this comment.
Since the FOCAL part in O2 is under construction, I suggest to not remove anything please.
|
Hi @vkucera, Some of the MID code proposed to be suppressed in this PR has been used for analyses on some tests bench. If there is no necessity to remove the code, I would prefer that we keep it. @dstocco can you confirm what needs to be kept for MID? I am also checking for the MCH files with @aferrero2707 @pillot and other muon experts, please do not go ahead with removing code before our feedbacks. Thanks, |
|
In the past we were indeed using the MID decoded-data-dump-workflow. However, looking now at this PR, I realise that the code is not in a CMakeLists.txt, so indeed it does not seem to be compiled. |
|
@vkucera please remove the changes to any ITS2&3 code. In the former case, I will open a PR soon where this is anyways done, in the latter its plainly wrong that the digit reader/writer is not built, will fix soon. |
Recovered |
|
Error while checking build/O2/fullCI_slc9 for 3cbb2f9 at 2026-01-21 22:50: Full log here. |
|
Hi @vkucera : Thx for the effort. From the GPU folder, please delete only makefile_opencl_compiler.cxx, opencl_compiler_structs.h, opencl_obtain_program.h. and GPUTPCDefinitions.h. All the other files in the GPU folder are needed in certain build cases, or for manual QA / tests. In general, I am not sure if we really need to do such a cleanup. Also other people / projects might have files for manual tests in here, so I would wait for feedback before merging, and I would send a mail to o2-wp-all and to the detectors, to double-check. |
|
How about you do smaller PRs with this, targeting one or two files? It should make it easier to review / approve. |
Hi @davidrohr , thanks for checking. I will make a separate PR. |
I can split it by first-level directory. |
There are quite a few files which appear to be unused (i.e. neither included nor compiled).
Please check whether any of them are used outside the repository or should be kept for other reasons.