configuration: more default links; small corrections / additions#161
Open
mrienstra wants to merge 1 commit intoActivityWatch:masterfrom
Open
configuration: more default links; small corrections / additions#161mrienstra wants to merge 1 commit intoActivityWatch:masterfrom
mrienstra wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 1ee0145 in 1 minute and 4 seconds. Click for details.
- Reviewed
80lines of code in2files - Skipped
0files when reviewing. - Skipped posting
8draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/configuration.rst:13
- Draft comment:
Renamed 'aw-server-python' to 'aw-server' for consistency with the repo name. Ensure all references are updated accordingly. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. src/configuration.rst:20
- Draft comment:
Added the 'custom_static' option with a link to custom visualizations. Verify that the anchor 'custom-visualizations' exists in the docs. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/configuration.rst:28
- Draft comment:
Changed the config key from 'host' to 'address' in the aw-server-rust section. This aligns with the actual implementation. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. src/configuration.rst:31
- Draft comment:
Added the 'custom_static' option for aw-server-rust, mirroring the aw-server configuration. Looks consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. src/configuration.rst:41
- Draft comment:
Updated the description for 'client.commit_interval' for clarity. The new phrasing is clearer. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. src/configuration.rst:57
- Draft comment:
Replaced 'exclude_title' with 'exclude_titles' in the aw-watcher-window section. Confirm that this updated key matches the implementation. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
7. src/configuration.rst:60
- Draft comment:
Enhanced inline code formatting for macOS strategies (swift,jxa,applescript) for consistency and readability. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
8. src/watchers.rst:85
- Draft comment:
Added the '.. _custom-visualizations:' anchor to facilitate linking from configuration docs. Good addition for navigability. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_QwLaPuxCtpxWY7Yy
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only the
aw-watcher-afksection has a link to the default config values, this PR adds links for all sections.Additionally:
aw-server-pythontoaw-server(to match repo name)custom_staticoption toaw-server&aw-server-rustaw-server-rusthasaddressoption, nothostlikeaw-serverexclude_titlesoption toaw-watcher-windowImportant
Add default config links, correct options, and minor additions to
configuration.rstandwatchers.rst.aw-server,aw-server-rust,aw-client, andaw-watcher-windowinconfiguration.rst.aw-server-pythontoaw-serverinconfiguration.rst.custom_staticoption toaw-serverandaw-server-rust.aw-server-rustto useaddressinstead ofhost.exclude_titlesoption toaw-watcher-window.watchers.rst.This description was created by
for 1ee0145. You can customize this summary. It will automatically update as commits are pushed.