Add tip for absolute Exec path in documentation#156
Open
dleiferives wants to merge 2 commits intoActivityWatch:masterfrom
Open
Add tip for absolute Exec path in documentation#156dleiferives wants to merge 2 commits intoActivityWatch:masterfrom
dleiferives wants to merge 2 commits intoActivityWatch:masterfrom
Conversation
Added a tip about replacing the Exec path with an absolute one in the running-on-gnome documentation. Sometime in the last 2 years seems like absolute path is required.
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 3a7f2d2 in 1 minute and 19 seconds. Click for details.
- Reviewed
21lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/running-on-gnome.rst:66
- Draft comment:
The example shows Exec using '~'. For clarity, explicitly note that desktop environments do not perform tilde expansion, so replacing it with an absolute path (e.g. '/home//...') is necessary. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is purely informative, explaining a behavior related to tilde expansion in desktop environments. It does not provide a suggestion, ask for confirmation, or point out a potential issue in the code. Therefore, it violates the rule against making purely informative comments.
Workflow ID: wflow_SsMXnJ23PktMWm0j
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a tip about replacing the Exec path with an absolute one in the running-on-gnome documentation.
Sometime in the last 2 years seems like absolute path is required.
Important
Adds a documentation tip in
running-on-gnome.rstfor using absolute paths inExecentries for GNOME desktop files.running-on-gnome.rstto replaceExecrelative paths with absolute paths in GNOME desktop files.Exec="~/.local/opt/activitywatch/kill.sh"toExec="/home/<your-username>/.local/opt/activitywatch/kill.sh".<your-username>with the actual username.This description was created by
for 3a7f2d2. You can customize this summary. It will automatically update as commits are pushed.