Path for aw-server-rust executable doesn't match the docs#145
Path for aw-server-rust executable doesn't match the docs#145Game4Move78 wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6f6e5c8 in 21 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/installing-from-source.rst:107
- Draft comment:
Updated path & binary name now match the build output. Confirm that users see the correct 'target/release/aw-server'. - Reason this comment was not posted:
Marked as duplicate.
2. src/installing-from-source.rst:107
- Draft comment:
Good update – the command now correctly points to target/release and uses the filename 'aw-server'. Ensure consistency across all related documentation (and consider noting any platform-specific executables, e.g. on Windows). - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_3tuDJisfkipQnWmO
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Seems we are not mentioning That's what puts it there as The proper fix is probably to mention |
|
Would also be good to mention |
When running
make buildas per the docs it stores in targetreleasenotpackage. The basename of the executable is alsoaw-servernotaw-server-rust.Related to ActivityWatch/aw-server-rust#500
Important
Update
installing-from-source.rstto correct the Rust server executable path and name.installing-from-source.rstto correct the path for the Rust server executable fromaw-server-rust/target/package/aw-server-rusttoaw-server-rust/target/release/aw-server.This description was created by
for 6f6e5c8. It will automatically update as commits are pushed.