fix GNOME desktop entry instructions#141
Open
meonkeys wants to merge 1 commit intoActivityWatch:masterfrom
Open
fix GNOME desktop entry instructions#141meonkeys wants to merge 1 commit intoActivityWatch:masterfrom
meonkeys wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
Gotta use absolute paths in `Exec` in `.desktop` files or they don't show up automatically. Not sure if this is true for everyone/always, but it was for me. Sources: https://bbs.archlinux.org/viewtopic.php?id=256867 https://discourse.gnome.org/t/application-entries-desktop-not-displayed/3670 https://discussion.fedoraproject.org/t/how-to-create-a-desktop-file-to-show-up-among-my-apps/128596/5 These sources indicate the underlying issue appears has to do with an issue with the user's non-interactive path, but I think the issue might actually be the tilde is not expanded. I didn't attempt to debug further, I just used an absolute path and it worked. Seems like the safer (and more annoying) way to go to make it work for most people. I do with tilde worked more reliably. FFR, my desktop right now is GNOME, as shipped with 64-bir Ubuntu 22.04 LTS. I think that means GNOME 3 and Wayland.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 8389e96 in 33 seconds
More details
- Looked at
31lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/running-on-gnome.rst:39
- Draft comment:
Remove the double quotes around the Exec path as they are unnecessary and could cause issues.
Exec=/home/user/.local/opt/activitywatch/start.sh
- Reason this comment was not posted:
Comment looked like it was already resolved.
2. src/running-on-gnome.rst:54
- Draft comment:
Remove the double quotes around the Exec path as they are unnecessary and could cause issues.
Exec=/home/user/.local/opt/activitywatch/kill.sh
- Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_15i3cuVwQpfy3Aud
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gotta use absolute paths in
Execin.desktopfiles or they don't show up automatically. Not sure if this is true for everyone/always, but it was for me.Sources:
https://bbs.archlinux.org/viewtopic.php?id=256867
https://discourse.gnome.org/t/application-entries-desktop-not-displayed/3670
https://discussion.fedoraproject.org/t/how-to-create-a-desktop-file-to-show-up-among-my-apps/128596/5
These sources indicate the underlying issue appears has to do with an issue with the user's non-interactive path, but I think the issue might actually be the tilde is not expanded. I didn't attempt to debug further, I just used an absolute path and it worked (they immediately started showing up when I press the "Super" key). Using an absolute path seems like the safer (and more annoying) way to go to make it work for most people. I do wish tilde worked more reliably.
FFR, my desktop right now is GNOME, as shipped with 64-bit Ubuntu 22.04 LTS. I think that means GNOME 3 and Wayland.
Important
Update GNOME desktop entry instructions to use absolute paths in
src/running-on-gnome.rst.src/running-on-gnome.rstto use absolute paths inExecfield of.desktopfiles for GNOME desktop entries.Exec="~/.local/opt/activitywatch/start.sh"withExec="/home/user/.local/opt/activitywatch/start.sh".Exec="~/.local/opt/activitywatch/kill.sh"withExec="/home/user/.local/opt/activitywatch/kill.sh".This description was created by
for 8389e96. It will automatically update as commits are pushed.