Update installing-from-source.rst#135
Update installing-from-source.rst#135mindflowgo wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
Adjusting the paths for venv, zsh was wrong, I'm assuming other 2 require similar changes.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to a4b5f16 in 57 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/installing-from-source.rst:76
- Draft comment:
The change in virtual environment activation paths from./venvto~/.venvcould lead to confusion since the virtual environment is initially created in the local directory (python3 -m venv venv). Users following the guide might not have a~/.venvdirectory, leading to errors when trying to activate the virtual environment.
source ./venv/Scripts/activate
- Reason this comment was not posted:
Marked as duplicate.
2. src/installing-from-source.rst:78
- Draft comment:
The change in virtual environment activation paths from./venvto~/.venvcould lead to confusion since the virtual environment is initially created in the local directory (python3 -m venv venv). Users following the guide might not have a~/.venvdirectory, leading to errors when trying to activate the virtual environment.
source ./venv/bin/activate.fish
- Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_N3YJ8g9S36iExBRx
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
|
||
| # For bash/zsh users: | ||
| source ./venv/bin/activate | ||
| source ~/.venv/bin/activate |
There was a problem hiding this comment.
The change in virtual environment activation paths from ./venv to ~/.venv could lead to confusion since the virtual environment is initially created in the local directory (python3 -m venv venv). Users following the guide might not have a ~/.venv directory, leading to errors when trying to activate the virtual environment.
| source ~/.venv/bin/activate | |
| source ./venv/bin/activate |
There was a problem hiding this comment.
On the mac, it creates a directory caled '.venv' with the period to make it a hidden directory. Thus you could resolve the bot dispute to: source ./.venv/bin/activate
Adjusting the paths for venv, zsh was wrong, I'm assuming other 2 require similar changes.
Summary:
Updated virtual environment activation paths in
src/installing-from-source.rstto use the home directory instead of the current directory.Key points:
src/installing-from-source.rstto change virtual environment activation paths.source ./venv/bin/activatetosource ~/.venv/bin/activate.source ./venv/Scripts/activatetosource ~/.venv/Scripts/activate.source ./venv/bin/activate.fishtosource ~/.venv/bin/activate.fish.Generated with ❤️ by ellipsis.dev