Conversation
dhensle
approved these changes
Dec 18, 2025
Contributor
dhensle
left a comment
dhensle
left a comment
There was a problem hiding this comment.
Fix looks good. Suggest we add more detail to the change log, and one minor typo to fix.
| coef_N_88,-0.05952606764773704,-0.05952606764773704,0.87709999999999999,0 | ||
| coef_N_xxx,-0.89914972777069246,-0.89914972777069246,-0.36530000000000001,0 | ||
| coef_N_xxxx,-0.72130413279127681,-0.72130413279127681,-1.3460000000000001,0 | ||
| coef_N_xxxxx,-6.6290578146794195,-6.6290578146794195,-3.4529999999999998,0 |
Contributor
There was a problem hiding this comment.
Happy to see the additional coef_xxx and coef_xxxx coefficients. All these coefficients across M,N, and H make a lot more sense now with a strong negative coefficient for everyone in a 5-person household doing the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an error in Larch estimation of the CDAP model, reported in #595. There was a bug in the code, where interaction terms for 3, 4, and 5 person households adopting an all-M, all-N, or all-H patterns were all mapped to the same coefficient; the original model structure has unique parameters for each household size. [1] [2]
Testing and validation
test_cdap_modeltest to include assertions verifying the correct assignment of interaction parameters, specifically checking the presence and absence of wildcard coefficients for different model sizes.test_cdap_model_loglike.csvto reflect changes in log-likelihood values resulting from the repaired coefficient mapping logic.