Draft
Conversation
Update News and patch level.
Based off of: 401f9f3 and python-cmake-buildsystem@97fa07c
This should be handled dynmically by the new compiler.
ucodery
approved these changes
Aug 13, 2024
Comment on lines
+22
to
+23
| if majorVersion >= 13: | ||
| majorVersion += 1 |
There was a problem hiding this comment.
I saw the comment in all the other places this was done. Still not sure I understand it, but a reason was given.
| # Use the .lib files for the correct architecture | ||
| if self.plat_name == 'win32': | ||
| suffix = '' | ||
| suffix = 'win32' |
There was a problem hiding this comment.
This leaves suffix undefined in certain circumstances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review additional Compiler Updates