Don't complete multi-state entries until they're actually done.#30
Open
mtstickney wants to merge 1 commit intoAccelerationNet:masterfrom
Open
Don't complete multi-state entries until they're actually done.#30mtstickney wants to merge 1 commit intoAccelerationNet:masterfrom
mtstickney wants to merge 1 commit intoAccelerationNet:masterfrom
Conversation
When matching a multi-state entry, we need to differentiate between determining whether the entry matches, and completing that state. A multi- state entry should only be completed when we've reached the last of its states. This is accomplished by returning the the completion function or NIL as the the primary value from CHECK-TABLE-ENTRY, and a secondary value indicating whether the entry matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When matching a multi-state entry, we need to differentiate between
determining whether the entry matches, and completing that state. A multi-
state entry should only be completed when we've reached the last of its
states. This is accomplished by returning the the completion function or
nilas the the primary value fromcheck-table-entry, and a secondary valueindicating whether the entry matched.
Currently, the completion function is always called when the entry matches,
which manifests as the following bug (using interpol syntax for strings):