Playerside sign update

[Intybyte]

Describe in detail what your pull request accomplishes

Use a bukkit method to force the player to update the signs instead

Related issues:

• Fixes Remove unnecessary sign updates #671

Checklist

• Tested
• Performance tested

[TylerS1066]

I ran a test and this does not fully work yet. It's better than before (without any update packets), but not fully working.

[Intybyte]

not fully working.
What do you mean with not fully working? like sometimes it works sometimes it doesn't?

[TylerS1066]

What do you mean with not fully working? like sometimes it works sometimes it doesn't?

Correct, it worked some of the time but not all. I didn't try it for long, but there didn't seem to be a pattern (I was just cruising a ship a bit and sometimes the sign would update, sometimes not).

[oh-noey]

the api you're using is marked as deprecated in recent javadoc, which could signal why its broken. Try using the alternative method they recommend instead.

[Intybyte]

the api you're using is marked as deprecated in recent javadoc, which could signal why its broken. Try using the alternative method they recommend instead.

Ok just read the java docs

Use sendBlockUpdate(Location, TileState) by creating a new virtual Sign block state via BlockData.createBlockState() (constructed e.g.

I will try using the suggested method, I hope the createBlockState() calls aren't as expensive as the original server update call otherwise it would be a waste of time