[Feature / Cleanup] Sign rework (WIP)#679
Open
DerToaster98 wants to merge 123 commits intoAPDevTeam:mainfrom
Open
[Feature / Cleanup] Sign rework (WIP)#679DerToaster98 wants to merge 123 commits intoAPDevTeam:mainfrom
DerToaster98 wants to merge 123 commits intoAPDevTeam:mainfrom
Conversation
Contributor
This would be best left for a separate PR. I believe there are many assumptions that Subcrafts never move, so we'll have to do a through review of the codebase for that feature. |
Contributor
Author
Alright, i will remove that from the todo list. Will implement the other points nonetheless |
it is a bit ugly to register it twice but i think that's just alright. Alternatively we could just create a empty sign change listener for the [Helm] stuff and roll with that
…t the craft that the sign is on
…again (cherry picked from commit a307803)
(cherry picked from commit 7075208)
…puteIfAbsent (cherry picked from commit e8896a2)
…d too (cherry picked from commit 039756d)
(cherry picked from commit 956053d)
(cherry picked from commit 9a40431)
(cherry picked from commit 232ab10)
(cherry picked from commit 91ff872)
(cherry picked from commit 3f8dfdb)
(cherry picked from commit 633f33c)
(cherry picked from commit 3aa0dc9)
(cherry picked from commit 5e0ed2e)
(cherry picked from commit 88baa63)
(cherry picked from commit 1853ba7)
(cherry picked from commit 2316876)
(cherry picked from commit 238e989)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
This PR is a attempt at redoing signs in a more organized way.
That encompasses the following things:
TODO List:
[ ] NEW Subcraft MovePostpone for later, this requires thorough analysis priorChecklist