This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Compatibility with AFNetworking 3 and HTTP/2#22
Open
abbasmousavi wants to merge 8 commits intoAFNetworking:masterfrom
Open
Compatibility with AFNetworking 3 and HTTP/2#22abbasmousavi wants to merge 8 commits intoAFNetworking:masterfrom
abbasmousavi wants to merge 8 commits intoAFNetworking:masterfrom
Conversation
abbasmousavi
changed the title
abbasmousavi
changed the title
Author
|
@mattt @kylef @cnoon @kcharwood @wiistriker |
AFJSONRPCClient/AFJSONRPCClient.h
Outdated
| // THE SOFTWARE. | ||
|
|
||
| #import "AFHTTPRequestOperationManager.h" | ||
| #import "AFHTTPSessionManager.h" |
There was a problem hiding this comment.
This should probably just import AFNetworkings framework header.
#import <AFNetworking/AFNetworking.h>
Author
|
@kylef Yes, I have fixed it. Thanks. |
handya
approved these changes
Dec 10, 2016
kylef
reviewed
Dec 11, 2016
AFJSONRPCClient.podspec
Outdated
| s.tvos.deployment_target = '9.0' | ||
|
|
||
| s.dependency 'AFNetworking', '~> 2.1' | ||
| s.dependency 'AFNetworking', '> 2.1' |
There was a problem hiding this comment.
I think it would be better to lock to ~> 3.0 or perhaps a range of > 2.1, < 4.0 if AFNetworking 2 should still be supported. Otherwise any breaking changes in AFNetworking 4.0 would break AFJSONRPCClient.
Author
There was a problem hiding this comment.
This code only works with AFNetworking 3.0, It is better to lock it to ~> 3.0.
We can create a branch with current code for AFNetworking 2.0 if anyone uses it.
I have changed it in a new commit.
@kylef
Author
Author
|
Any chance of getting this checked in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using AFHTTPSessionManager instead of AFHTTPRequestOperation so that we can use AFJSONRPCClient with AFNetworking 3 and send JSON-RPC request over HTTP/2