Feat: Allow Invoice Items to have Notes

[tomas-goncalves]

Allow Invoice Items to have notes. Uses this existing feature to help standardize items that need the same consistent note (e.g. Rangos Installed Lighting System).

[DaAwesomeP]

It feels like this should play into #603 and the placeholder/initial text for invoice lines should come from invoice items (instead of being hardcoded in Ruby).

[tomas-goncalves]

I thought about this after. I think they work for different purposes and are complementary, especially considering we don't want to have much pricing information in tracker for simplicity of updating.

One is a standard disclaimer we add to all Labor line items. The other one is for very specific items that need disclaimers.

I think having both is good for the final goal of spending less time on quote making, but this is definitely open to discussion.

[DaAwesomeP]

I guess I am confused what the functional difference is between a memo and a note? Because every line already has a free-form text field in the form of the memo (which is called "Description" on the exported PDFs). What information would go in a note that you wouldn't put in a memo? This will also add another column to the quote/invoice which will squeeze things on a standard letter PDF I think.

[DaAwesomeP]

Ah, I see my confusion. I am conflating invoice items and lines. So you want to pre-populate an invoice note from an invoice item. Makes sense.

However I do think this solves Labor category pre-populating too (#603). You would just have an Invoice Item/Preset called "Labor" to functionally have the same result.

[tomas-goncalves]

@DaAwesomeP are you opposed to merging this PR? I think we agree it's a good idea. Then we can test it and if we feel there's still a necessity for #603 I'll revisit it

[NoRePercussions]

I'll try to run it later but looks fine

[DaAwesomeP]

@DaAwesomeP are you opposed to merging this PR? I think we agree it's a good idea. Then we can test it and if we feel there's still a necessity for #603 I'll revisit it

Hey sorry I missed this. Looks good to me, just see my suggested edits (some duplicated columns and lines maybe).

[tomas-goncalves]

Fixed all comments @DaAwesomeP can we merge this then redeploy tracker?