added read-only access to pin direction and subcategory object#639
Open
dfb wants to merge 1 commit into20tab:masterfrom
Open
added read-only access to pin direction and subcategory object#639dfb wants to merge 1 commit into20tab:masterfrom
dfb wants to merge 1 commit into20tab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When analyzing a graph node's pins, it's really helpful to know which direction the pin is, so this patch adds read support via pin.direction.
Also, I found that many pins in existing BPs that have a structure for their type have category = 'struct' but sub_category=None, default_object=None, etc. - there's no good way (that I could find at least) to programmatically figure out the pin's structure type.
In the debugger, however, I noticed that the structure is available via pin.PinType.PinSubCategoryObject, so this patch also exposes read access to that as pin.sub_category_object.