DO NOT MERGE -- Draft PR -- Refactor metric color-coding logic in AB Dash#6
Draft
michael-furchtgott wants to merge 4 commits intomainfrom
Draft
DO NOT MERGE -- Draft PR -- Refactor metric color-coding logic in AB Dash#6michael-furchtgott wants to merge 4 commits intomainfrom
michael-furchtgott wants to merge 4 commits intomainfrom
Conversation
Co-authored-by: michael.furchtgott <michael.furchtgott@chime.com>
|
Cursor Agent can help with this pull request. Just |
michael-furchtgott
changed the title
michael-furchtgott
changed the title
Co-authored-by: michael.furchtgott <michael.furchtgott@chime.com>
Co-authored-by: michael.furchtgott <michael.furchtgott@chime.com>
Co-authored-by: michael.furchtgott <michael.furchtgott@chime.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor metric color-coding and experiment count logic to use dynamic optimization direction from a metadata table.
The previous implementation relied on a hard-coded list of "bad" metrics within the LookML view itself, making it difficult to maintain and extend. This change introduces a
STATS_ENGINE_EXP_METRIC_METADATAtable with anOPTIMIZE_DIRECTIONcolumn, allowing the Looker dashboard to dynamically determine if a metric should be optimized 'UP' or 'DOWN' for color-coding and counting statistically significant experiments. This improves maintainability and flexibility.