fix: prevent duplicate todo ids by using Date.now()#1
Open
time1043 wants to merge 3 commits into13RTK:mainfrom
Open
fix: prevent duplicate todo ids by using Date.now()#1time1043 wants to merge 3 commits into13RTK:mainfrom
Date.now()#1time1043 wants to merge 3 commits into13RTK:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Currently, new todo items use
id: currentTodoList.length + 1to generate IDs.This causes duplicate IDs when an item is deleted and then a new one is added.
Reproduction steps:
See the attached screenshot for an example (two items with the same id=10: "Rust" and "aa").

Solution
Ensure IDs are always unique when adding todos.
For simplicity, replace the ID generation with
Date.now(), which guarantees uniqueness.