From e8c05f1fa3e79aa8d8cea330a096100b683ab973 Mon Sep 17 00:00:00 2001 From: Daniel Gohlke Date: Thu, 29 Jan 2026 09:47:50 +0100 Subject: [PATCH 1/2] [BUGFIX] Move module configuration to page.tsconfig The file ext_typoscript_setup.typoscript will be ignored in case using Site Sets in TYPO3. see: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/FileStructure/ExtTyposcriptSetupTyposcript.html Relates: #732 --- Configuration/page.tsconfig | 21 +++++++++++++++++++++ ext_typoscript_setup.typoscript | 21 --------------------- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/Configuration/page.tsconfig b/Configuration/page.tsconfig index a04b17b9..cf5cee80 100644 --- a/Configuration/page.tsconfig +++ b/Configuration/page.tsconfig @@ -1,2 +1,23 @@ # Template path for dashboard widgets templates.typo3/cms-dashboard.1712899110 = extcode/cart:Resources/Private/ + +tx_cart { + persistence { + storagePid = {$module.tx_cart.persistence.storagePid} + } + + settings { + format.currency { + currencySign = {$plugin.tx_cart.settings.format.currency.currencySign} + decimalSeparator = {$plugin.tx_cart.settings.format.currency.decimalSeparator} + thousandsSeparator = {$plugin.tx_cart.settings.format.currency.thousandsSeparator} + prependCurrency = {$plugin.tx_cart.settings.format.currency.prependCurrency} + separateCurrency = {$plugin.tx_cart.settings.format.currency.separateCurrency} + decimals = {$plugin.tx_cart.settings.format.currency.decimals} + } + + backend { + dateFormat = {$plugin.tx_cart.settings.backend.dateFormat} + } + } +} diff --git a/ext_typoscript_setup.typoscript b/ext_typoscript_setup.typoscript index d2f642b9..ac4c5f5b 100644 --- a/ext_typoscript_setup.typoscript +++ b/ext_typoscript_setup.typoscript @@ -1,24 +1,3 @@ -module.tx_cart { - persistence { - storagePid = {$module.tx_cart.persistence.storagePid} - } - - settings { - format.currency { - currencySign = {$plugin.tx_cart.settings.format.currency.currencySign} - decimalSeparator = {$plugin.tx_cart.settings.format.currency.decimalSeparator} - thousandsSeparator = {$plugin.tx_cart.settings.format.currency.thousandsSeparator} - prependCurrency = {$plugin.tx_cart.settings.format.currency.prependCurrency} - separateCurrency = {$plugin.tx_cart.settings.format.currency.separateCurrency} - decimals = {$plugin.tx_cart.settings.format.currency.decimals} - } - - backend { - dateFormat = {$plugin.tx_cart.settings.backend.dateFormat} - } - } -} - config.pageTitleProviders { cart { provider = Extcode\Cart\PageTitle\PageTitleProvider From dc52d5d92863ddbad99a3cf9b15beb546d4f2bb1 Mon Sep 17 00:00:00 2001 From: Daniel Gohlke Date: Thu, 29 Jan 2026 09:56:50 +0100 Subject: [PATCH 2/2] [BUGFIX] Add check for empty format configuration Changing the condition in the ViewHelper was mentioned in PR #713. This won't fix the problem that configuration was not available in backend module. Relates: #732 Closes: #713 --- Classes/ViewHelpers/Format/CurrencyViewHelper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/ViewHelpers/Format/CurrencyViewHelper.php b/Classes/ViewHelpers/Format/CurrencyViewHelper.php index 3fa1ad3d..2f33f79f 100644 --- a/Classes/ViewHelpers/Format/CurrencyViewHelper.php +++ b/Classes/ViewHelpers/Format/CurrencyViewHelper.php @@ -102,7 +102,7 @@ public function render(): string $settings = $this->templateVariableContainer->get('settings'); - if ($settings && $settings['format'] && $settings['format']['currency']) { + if (isset($settings['format']['currency']) && is_array($settings['format']['currency'])) { $currencyFormat = $settings['format']['currency']; if (!isset($currencySign) && isset($currencyFormat['currencySign'])) {