From 5faa9038a980eb2e1c3fa055fe623fa2f0669948 Mon Sep 17 00:00:00 2001 From: MDSAM05 Date: Fri, 30 Jan 2026 13:46:50 +0530 Subject: [PATCH 1/2] feat: update suggestion menu component --- packages/ariakit/src/suggestionMenu/SuggestionMenuItem.tsx | 7 +++---- .../gridSuggestionMenu/GridSuggestionMenuItem.tsx | 7 +++---- packages/mantine/src/suggestionMenu/SuggestionMenuItem.tsx | 6 ++---- .../gridSuggestionMenu/GridSuggestionMenuItem.tsx | 7 +++---- 4 files changed, 11 insertions(+), 16 deletions(-) diff --git a/packages/ariakit/src/suggestionMenu/SuggestionMenuItem.tsx b/packages/ariakit/src/suggestionMenu/SuggestionMenuItem.tsx index 68e3c6a7d4..7dfcbcaf5d 100644 --- a/packages/ariakit/src/suggestionMenu/SuggestionMenuItem.tsx +++ b/packages/ariakit/src/suggestionMenu/SuggestionMenuItem.tsx @@ -22,10 +22,9 @@ export const SuggestionMenuItem = forwardRef< document.querySelector(".bn-suggestion-menu, #ai-suggestion-menu")!, // TODO ); - if (overflow === "top") { - itemRef.current.scrollIntoView(true); - } else if (overflow === "bottom") { - itemRef.current.scrollIntoView(false); + + if (overflow !== "none") { + itemRef.current.scrollIntoView({ block: "nearest" }); } }, [isSelected]); diff --git a/packages/ariakit/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx b/packages/ariakit/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx index f1b0346e38..d84f433be6 100644 --- a/packages/ariakit/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx +++ b/packages/ariakit/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx @@ -22,10 +22,9 @@ export const GridSuggestionMenuItem = forwardRef< document.querySelector(".bn-grid-suggestion-menu")!, ); - if (overflow === "top") { - itemRef.current.scrollIntoView(true); - } else if (overflow === "bottom") { - itemRef.current.scrollIntoView(false); + + if (overflow !== "none") { + itemRef.current.scrollIntoView({ block: "nearest" }); } }, [isSelected]); diff --git a/packages/mantine/src/suggestionMenu/SuggestionMenuItem.tsx b/packages/mantine/src/suggestionMenu/SuggestionMenuItem.tsx index a8fbb8d2e6..fae9feb4da 100644 --- a/packages/mantine/src/suggestionMenu/SuggestionMenuItem.tsx +++ b/packages/mantine/src/suggestionMenu/SuggestionMenuItem.tsx @@ -30,10 +30,8 @@ export const SuggestionMenuItem = forwardRef< document.querySelector(".bn-suggestion-menu, #ai-suggestion-menu")!, // TODO ); - if (overflow === "top") { - itemRef.current.scrollIntoView(true); - } else if (overflow === "bottom") { - itemRef.current.scrollIntoView(false); + if (overflow !== "none") { + itemRef.current.scrollIntoView({ block: "nearest" }); } }, [isSelected]); diff --git a/packages/mantine/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx b/packages/mantine/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx index da86deb932..b695b24ddf 100644 --- a/packages/mantine/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx +++ b/packages/mantine/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx @@ -24,10 +24,9 @@ export const GridSuggestionMenuItem = forwardRef< document.querySelector(".bn-grid-suggestion-menu")!, ); - if (overflow === "top") { - itemRef.current.scrollIntoView(true); - } else if (overflow === "bottom") { - itemRef.current.scrollIntoView(false); + + if (overflow !== "none") { + itemRef.current.scrollIntoView({ block: "nearest" }); } }, [isSelected]); From 6b1d566384cf6c394c7f0918f88987111219f32a Mon Sep 17 00:00:00 2001 From: Matthew Lipski Date: Fri, 13 Feb 2026 17:56:48 +0100 Subject: [PATCH 2/2] Added fix to ShadCN --- packages/shadcn/src/suggestionMenu/SuggestionMenuItem.tsx | 7 +++---- .../gridSuggestionMenu/GridSuggestionMenuItem.tsx | 6 ++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/shadcn/src/suggestionMenu/SuggestionMenuItem.tsx b/packages/shadcn/src/suggestionMenu/SuggestionMenuItem.tsx index 025064596a..e89fd6432f 100644 --- a/packages/shadcn/src/suggestionMenu/SuggestionMenuItem.tsx +++ b/packages/shadcn/src/suggestionMenu/SuggestionMenuItem.tsx @@ -26,10 +26,9 @@ export const SuggestionMenuItem = forwardRef< itemRef.current, document.querySelector(".bn-suggestion-menu, #ai-suggestion-menu")!, // TODO ); - if (overflow === "top") { - itemRef.current.scrollIntoView(true); - } else if (overflow === "bottom") { - itemRef.current.scrollIntoView(false); + + if (overflow !== "none") { + itemRef.current.scrollIntoView({ block: "nearest" }); } }, [isSelected]); diff --git a/packages/shadcn/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx b/packages/shadcn/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx index aa01b44944..3bf4192007 100644 --- a/packages/shadcn/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx +++ b/packages/shadcn/src/suggestionMenu/gridSuggestionMenu/GridSuggestionMenuItem.tsx @@ -24,10 +24,8 @@ export const GridSuggestionMenuItem = forwardRef< document.querySelector(".bn-grid-suggestion-menu")!, ); - if (overflow === "top") { - itemRef.current.scrollIntoView(true); - } else if (overflow === "bottom") { - itemRef.current.scrollIntoView(false); + if (overflow !== "none") { + itemRef.current.scrollIntoView({ block: "nearest" }); } }, [isSelected]);