From 2c76d257ab80f740c47a536cef2a559207d019cf Mon Sep 17 00:00:00 2001 From: usernamealreadyis Date: Thu, 14 Jan 2016 07:48:49 +0700 Subject: [PATCH] Update DEVELOPER.md We recommend starting with ^, to only match strings at the beginning of a line. In our experience this makes approval more intentional, and also avoids issues with comments via email where previous content may be embedded in a blockquote (>) that could otherwise trigger mistaken approval. --- DEVELOPER.md | 1 + 1 file changed, 1 insertion(+) diff --git a/DEVELOPER.md b/DEVELOPER.md index aa162be51335..835b17b19d97 100644 --- a/DEVELOPER.md +++ b/DEVELOPER.md @@ -354,3 +354,4 @@ If you need to debug the tests: The `debugger;` statement is needed because WebStorm will stop in a transpiled file. Breakpoints in the original source files are not supported at the moment. +approve_regex: '^(Approved|:shipit:)'